Use maven based submission by default for samples #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaoyongzhu
added
the
safe to test
xiaoyongzhu
requested review from
Yuqing-cat,
blrchen and
jainr
and removed request for
Yuqing-cat,
blrchen and
jainr
xiaoyongzhu
changed the title
blrchen
approved these changes
Aug 24, 2022
|
How does the notebook get the jar from maven? |
jainr
approved these changes
Aug 24, 2022
Yeah if the |
ahlag
pushed a commit
to ahlag/feathr
that referenced
this pull request
Aug 26, 2022
* use maven based submission by default * Update Customer360.ipynb * Update product_recommendation_demo_advanced.ipynb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR has a few improvements:
feathr_runtime_locationin the samples so that users don't use them in the future. By removing thefeathr_runtime_locationconfig, Feathr will automatically using jars from maven.How was this PR tested?
Does this PR introduce any user-facing changes?